fix: clarify fee handling in SorobanInvokeTool and StellarPaymentTool#173
Merged
Dami24-hub merged 2 commits intoJun 26, 2026
Merged
Conversation
- SorobanInvokeTool: replace BASE_FEE with "0" and add comment explaining the initial fee is irrelevant since prepareSorobanTx overwrites it - StellarPaymentTool: add comment clarifying BASE_FEE is the actual fee for classic Stellar payments and is not overwritten - Remove unused BASE_FEE import from SorobanInvokeTool - .gitignore: remove !tests/__snapshots__/ forced-tracking line Closes Nodal-stellar#91
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91