Feat/webhook notifications#171
Merged
Dami24-hub merged 2 commits intoJun 26, 2026
Merged
Conversation
- Add backend/tools/DexOfferTool.ts with DexOfferInputSchema supporting create/update/delete actions via manageSellOffer - Wire dex_offer TaskType into PayFiAgent with spending limit guard - Add 10 tests covering happy path, delete, update, and validation - Fix pre-existing broken template literal in backend/network.ts
- Add WEBHOOK_URL and WEBHOOK_SECRET optional env vars to config - Add backend/webhook.ts with HMAC-SHA256 signing and axios POST - Retry webhook delivery up to 3 times via withRetry - Wire dispatchWebhook into PayFiAgent.run() on success and failure - Add 6 tests covering delivery, signature, no-op, and error swallowing
|
@GreatShinro Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add webhook notifications after every agent task
Summary
PayFiAgent previously had no way to notify external systems of task outcomes. This PR adds a fire-and-forget webhook system that POSTs
AgentResultas signed JSON to a configurable URL after everyrun()call — both success and failure.Changes
backend/config.tsTwo new optional env vars added to
EnvSchemaandAgentConfig:WEBHOOK_URLstring(URL)WEBHOOK_SECRETstringbackend/webhook.ts(new)signPayload(payload, secret)— returnsHMAC-SHA256hex digest of the payload stringdispatchWebhook(result)— no-ops ifWEBHOOK_URLis unset; otherwise:AgentResultto JSONX-Nodal-Signatureheader whenWEBHOOK_SECRETis setaxioswith up to 3 retries through the existingwithRetryhelperbackend/agent.tsdispatchWebhook(result)called (fire-and-forget viavoid) after both the success and failurereturn resultpaths inrun()tests/webhook.test.ts(new)6 tests:
signPayloadcorrectnessWEBHOOK_URLis unsetAgentResultas JSON to configured URLX-Nodal-Signatureheader matches expected HMACaxios.postrejectsTesting
Security Notes
WEBHOOK_SECRETnever appears in logs — it is only used insidesignPayloadand is not attached to the config object's public surface beyond the optional fieldlog.warn— a broken webhook endpoint cannot crash or stall the agentX-Nodal-SignatureagainstHMAC-SHA256(secret, rawBody)closes #113