Skip to content

Conversation

@doitchuu
Copy link
Member

@doitchuu doitchuu commented Mar 16, 2025

#9

2주차 정리 완료 했습니다 :)
이번 주도 고생 많으셨습니다!

@github-actions github-actions bot requested a review from tjd985 March 16, 2025 19:00
@tjd985 tjd985 added the 리뷰해주세욥 나는 지금 리뷰가 고프다 label Mar 18, 2025
Copy link
Contributor

@tjd985 tjd985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
코멘트 확인해주세요~😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const arr: Array<number> = [1, 2, 3]; // 위와 도일한 타입
const arr: Array<number> = [1, 2, 3]; // 위와 동일한 타입

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오타 수정 완료했어요! 👍

Comment on lines 85 to 91
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isValid는 에러가 발생하지 않나요?!
인덱스 시그니처는 number타입만 명시가 되어져 있는데, isValidboolean타입이여서 에러가 나지 않을까 싶어서요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크린샷 2025-03-20 오후 10 34 08

헛...에러가 발생하네요..!..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에러 발생으로 예시 수정 했씁니다!

@tjd985 tjd985 added 오타있어요! 오타 뭐에용😟 잘 봤습니다 👍🏻 굿잡.. 고생하셨습니다 🫡 고생한 당신.. 쉬어라! and removed 리뷰해주세욥 나는 지금 리뷰가 고프다 labels Mar 20, 2025
@doitchuu doitchuu requested a review from tjd985 March 20, 2025 22:57
@tjd985 tjd985 added 빠른 수정 감사합니다 ^__^ 우사인 볼트도 울고 갈 수정 속도 머지 하세요! 이제 당신에게 남은건 merge뿐이야.. and removed 오타있어요! 오타 뭐에용😟 잘 봤습니다 👍🏻 굿잡.. labels Mar 21, 2025
@doitchuu doitchuu merged commit 01af456 into main Mar 21, 2025
@doitchuu doitchuu deleted the week2_seulgi branch March 21, 2025 01:08
@tjd985 tjd985 linked an issue Mar 24, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

고생하셨습니다 🫡 고생한 당신.. 쉬어라! 머지 하세요! 이제 당신에게 남은건 merge뿐이야.. 빠른 수정 감사합니다 ^__^ 우사인 볼트도 울고 갈 수정 속도

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2주차 정리

3 participants