-
Notifications
You must be signed in to change notification settings - Fork 91
[docs] lazydocs to mkdocstrings #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@elephaint This PR is ready, but I can't figure the latex rendering issue from the docstrings, everything else looks good! |
elephaint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @deven367 , great work! Mostly minor comments 👍
nasaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @deven367! 🎉
Just a final comment: you've updated the installer for the build-docs however it doesn't install the dependecy when installing. Do you think that we should add this into the project.optional-dependencies inside the pyproject.toml?
elephaint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
elephaint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, one minor comment
elephaint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!!


This PR does the migration from
lazydocstomkdocstrings