Nixpkgs committers: Refer to new repo and switch to PR nominations #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| There are over 200 Nixpkgs committers with access to merge any PR. | ||
| To become a Nixpkgs committer, you can apply [in this issue](https://github.com/NixOS/nixpkgs/issues/321665). | ||
| There are [200 Nixpkgs committers](https://github.com/NixOS/nixpkgs-committers/tree/main/members) with access to merge any PR. | ||
| To become a Nixpkgs committer, you can nominate by following [these instructions](https://github.com/NixOS/nixpkgs-committers?tab=readme-ov-file#nominations). |
There was a problem hiding this comment.
I agree it's better to use "nominate" instead of "apply", but as-is the phrasing feels off.
I think for "nominate" to feel natural, you have to specify who is being nominated.
Suggested change
| To become a Nixpkgs committer, you can nominate by following [these instructions](https://github.com/NixOS/nixpkgs-committers?tab=readme-ov-file#nominations). | |
| To become a Nixpkgs committer, you can nominate yourself by following [these instructions](https://github.com/NixOS/nixpkgs-committers?tab=readme-ov-file#nominations). |
This wrongly implies you can't nominate others. That's no worse than the existing wording, but maybe we can take this opportunity to improve on it?
This feels a bit wordy though and I'm currently lacking inspiration:
Suggested change
| To become a Nixpkgs committer, you can nominate by following [these instructions](https://github.com/NixOS/nixpkgs-committers?tab=readme-ov-file#nominations). | |
| You can nominate yourself — or another contributor — to become a Nixpkgs committer. | |
| This should be done by following [these instructions](https://github.com/NixOS/nixpkgs-committers?tab=readme-ov-file#nominations). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #91
Depends on NixOS/nixpkgs-committers#34, which should be approved by all @NixOS/commit-bit-delegation members to satisfy the process.