Skip to content

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Apr 29, 2025

This adds pythreejs, providing interactive 3D graphics for the Jupyter Notebook and JupyterLab, using Three.js and Jupyter Widgets.

It also fixes the build failure in ipydatawidgets, a dependency.

I successfully ran the Animation.ipynb example on aarch64-linux.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@flokli flokli requested a review from GaetanLepage April 29, 2025 12:07
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 29, 2025
@nix-owners nix-owners bot requested a review from natsukium April 29, 2025 12:09
Copy link
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 29, 2025
@nix-owners nix-owners bot requested a review from bcdarwin April 29, 2025 12:15
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 402804


x86_64-linux

❌ 2 packages failed to build:
  • python313Packages.pythreejs
  • python313Packages.pythreejs.dist
✅ 6 packages built:
  • python312Packages.ipydatawidgets
  • python312Packages.ipydatawidgets.dist
  • python312Packages.pythreejs
  • python312Packages.pythreejs.dist
  • python313Packages.ipydatawidgets
  • python313Packages.ipydatawidgets.dist

aarch64-linux

❌ 2 packages failed to build:
  • python313Packages.pythreejs
  • python313Packages.pythreejs.dist
✅ 6 packages built:
  • python312Packages.ipydatawidgets
  • python312Packages.ipydatawidgets.dist
  • python312Packages.pythreejs
  • python312Packages.pythreejs.dist
  • python313Packages.ipydatawidgets
  • python313Packages.ipydatawidgets.dist

x86_64-darwin

❌ 8 packages failed to build:
  • python312Packages.ipydatawidgets
  • python312Packages.ipydatawidgets.dist
  • python312Packages.pythreejs
  • python312Packages.pythreejs.dist
  • python313Packages.ipydatawidgets
  • python313Packages.ipydatawidgets.dist
  • python313Packages.pythreejs
  • python313Packages.pythreejs.dist

aarch64-darwin

❌ 8 packages failed to build:
  • python312Packages.ipydatawidgets
  • python312Packages.ipydatawidgets.dist
  • python312Packages.pythreejs
  • python312Packages.pythreejs.dist
  • python313Packages.ipydatawidgets
  • python313Packages.ipydatawidgets.dist
  • python313Packages.pythreejs
  • python313Packages.pythreejs.dist

@flokli flokli force-pushed the pythreejs branch 2 times, most recently from 1760495 to 292e928 Compare April 29, 2025 15:13
@flokli
Copy link
Contributor Author

flokli commented Apr 29, 2025

@GaetanLepage indeed the build is broken for 3.13, due to jupyter-widgets/pythreejs#420.

Fixed :-)

@flokli flokli requested a review from Sigmanificient April 29, 2025 15:13
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 402804


x86_64-linux

✅ 8 packages built:
  • python312Packages.ipydatawidgets
  • python312Packages.ipydatawidgets.dist
  • python312Packages.pythreejs
  • python312Packages.pythreejs.dist
  • python313Packages.ipydatawidgets
  • python313Packages.ipydatawidgets.dist
  • python313Packages.pythreejs
  • python313Packages.pythreejs.dist

aarch64-linux

✅ 8 packages built:
  • python312Packages.ipydatawidgets
  • python312Packages.ipydatawidgets.dist
  • python312Packages.pythreejs
  • python312Packages.pythreejs.dist
  • python313Packages.ipydatawidgets
  • python313Packages.ipydatawidgets.dist
  • python313Packages.pythreejs
  • python313Packages.pythreejs.dist

x86_64-darwin

❌ 8 packages failed to build:
  • python312Packages.ipydatawidgets
  • python312Packages.ipydatawidgets.dist
  • python312Packages.pythreejs
  • python312Packages.pythreejs.dist
  • python313Packages.ipydatawidgets
  • python313Packages.ipydatawidgets.dist
  • python313Packages.pythreejs
  • python313Packages.pythreejs.dist

aarch64-darwin

❌ 8 packages failed to build:
  • python312Packages.ipydatawidgets
  • python312Packages.ipydatawidgets.dist
  • python312Packages.pythreejs
  • python312Packages.pythreejs.dist
  • python313Packages.ipydatawidgets
  • python313Packages.ipydatawidgets.dist
  • python313Packages.pythreejs
  • python313Packages.pythreejs.dist

flokli added 2 commits April 29, 2025 19:16
This likely regressed after bumping to numpy 2.0. Disable the two
failing tests for now, issues have been opened upstream.
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 402804


x86_64-linux

✅ 8 packages built:
  • python312Packages.ipydatawidgets
  • python312Packages.ipydatawidgets.dist
  • python312Packages.pythreejs
  • python312Packages.pythreejs.dist
  • python313Packages.ipydatawidgets
  • python313Packages.ipydatawidgets.dist
  • python313Packages.pythreejs
  • python313Packages.pythreejs.dist

aarch64-linux

✅ 8 packages built:
  • python312Packages.ipydatawidgets
  • python312Packages.ipydatawidgets.dist
  • python312Packages.pythreejs
  • python312Packages.pythreejs.dist
  • python313Packages.ipydatawidgets
  • python313Packages.ipydatawidgets.dist
  • python313Packages.pythreejs
  • python313Packages.pythreejs.dist

x86_64-darwin

✅ 8 packages built:
  • python312Packages.ipydatawidgets
  • python312Packages.ipydatawidgets.dist
  • python312Packages.pythreejs
  • python312Packages.pythreejs.dist
  • python313Packages.ipydatawidgets
  • python313Packages.ipydatawidgets.dist
  • python313Packages.pythreejs
  • python313Packages.pythreejs.dist

aarch64-darwin

✅ 8 packages built:
  • python312Packages.ipydatawidgets
  • python312Packages.ipydatawidgets.dist
  • python312Packages.pythreejs
  • python312Packages.pythreejs.dist
  • python313Packages.ipydatawidgets
  • python313Packages.ipydatawidgets.dist
  • python313Packages.pythreejs
  • python313Packages.pythreejs.dist

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaetanLepage GaetanLepage merged commit 2f5eba6 into NixOS:master Apr 29, 2025
25 of 29 checks passed
@flokli flokli deleted the pythreejs branch April 29, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants