-
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
python312Packages.pythreejs: init at 2.4.1 #402804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall.
|
1760495
to
292e928
Compare
@GaetanLepage indeed the build is broken for 3.13, due to jupyter-widgets/pythreejs#420. Fixed :-) |
|
This likely regressed after bumping to numpy 2.0. Disable the two failing tests for now, issues have been opened upstream.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds pythreejs, providing interactive 3D graphics for the Jupyter Notebook and JupyterLab, using Three.js and Jupyter Widgets.
It also fixes the build failure in ipydatawidgets, a dependency.
I successfully ran the
Animation.ipynb
example on aarch64-linux.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.