rofi: add IME support #387135
Merged
rofi: add IME support #387135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
github-actions
bot
added
10.rebuild-darwin: 0
|
Works with fine fcitx5. 👍 |
teto
reviewed
Mar 5, 2025
| @@ -23,6 +23,9 @@ | |||
| check, | |||
| glib, | |||
| buildPackages, | |||
|
|
|||
| imeSupport ? false, | |||
There was a problem hiding this comment.
dunno its impact on closure size but if it's not too much I would say we could always use ime.
It's 2025 and IME + wayland should be defaults IMO.
There was a problem hiding this comment.
Thanks for the review, yeah I wondered about having it by default, I pushed a new version without the imeSupport flag
bew
force-pushed
the
add-rofi-ime-support
branch
from
82be074 to
5e38027
Compare
github-actions
bot
added
10.rebuild-linux: 11-100
|
looks ok in terms of closure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should add IME support for Rofi.
I have never used IMEs and don't know how to set them up, but I've looked at the PR that added IME support in Rofi (shows use of
xcb-imdkit) and the currentmeson.build#L89 for how to enable use of this lib (withimdkit=truemeson option).Resolves #387025
👉 I need someone to test that this is enough to make rofi work with IMEs
QUESTION: should I add a line in release notes?
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.