create-nixos-amis: packages nixos/maintainers/scripts/ec2/create-amis.sh #277079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `create-nixos-amis` derivation for the `nixos/maintainers/scripts/ec2/create-amis.sh` script such that `nixpkgs` users can easily call this script as well to create their own custom NixOS AMIs.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
@ofborg build create-nixos-amis |
|
@arianvp care to take a look at this? |
|
I realise NixOS/infra#254 is a a better way forward, so closing this PR. |
|
Sorry for the late response. Please have a look at https://GitHub.com/nixos/amis . The upload script i use there is exposed as a flake. It has some neat properties like being fully idempotent. It'll also be the place where I will run the automation to regularly update the AMIs going forward. |
|
I'm planning to upstream the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds the
create-nixos-amisderivation for thenixos/maintainers/scripts/ec2/create-amis.shscript such thatnixpkgsusers can easily call this script as well to create their own custom NixOS AMIs.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.