Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vagrant: 2.2.19 -> 2.3.4 #228969

Closed
wants to merge 1 commit into from
Closed

vagrant: 2.2.19 -> 2.3.4 #228969

wants to merge 1 commit into from

Conversation

jerith666
Copy link
Contributor

required for ruby 3.1 compatibility

three hand-edits to the regenerated gemset.nix were required:

  • fix the hashes for google-protobuf and gprc

  • remove the 'vagrant' entry

hashicorp/vagrant@v2.2.19...v2.3.4

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Member

wegank commented Apr 29, 2023

So... mark as broken on darwin?

@jerith666
Copy link
Contributor Author

I don't know -- I don't have a darwin machine to test on. I don't have any reason to believe 2.3.4 would be any more or less broken on darwin than 2.2.19 was, though.

@wegank
Copy link
Member

wegank commented Apr 29, 2023

2.2.19 actually built on darwin (https://hydra.nixos.org/job/nixpkgs/trunk/vagrant.aarch64-darwin), so the upgrade definitely leads to a regression there.

@jerith666
vagrant: 2.2.19 -> 2.3.4
1d69b01 
required for ruby 3.1 compatibility.

this version does not build on darwin; it fails with:

strip: error: symbols referenced by indirect symbol table entries that can't be stripped in:
/nix/store/kii5l64n3v0wml7iyqm1swzhgqljjky4-ruby3.1.4-grpc-1.54.0/lib/ruby/gems/3.1.0/gems/grpc-1.54.0/src/ruby/ext/grpc/grpc_c.bundle

three hand-edits to the regenerated gemset.nix were also required:

* fix the hashes for google-protobuf and gprc

* remove the 'vagrant' entry
@jerith666
Copy link
Contributor Author

Okay, sorry, I'm not very practiced at reading the ofborg PR checks.

I found the log at https://logs.ofborg.org/?key=nixos/nixpkgs.228969&attempt_id=4e885d98-2038-4077-832b-3f96f0517818, and I don't know nearly enough about darwin or ruby to make much sense of that.

I just pushed a version that removes darwin from meta.platforms. :(

@wegank
Copy link
Member

wegank commented Apr 29, 2023 •
edited
Loading

I just pushed a version that removes darwin from meta.platforms. :(

Nope, please just mark darwin as broken in meta.broken instead. meta.platforms is perfectly valid.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Apr 29, 2023
@risicle
Copy link
Contributor

risicle commented Apr 30, 2023

It's also worth searching for existing PRs before you create one - this is the third attempted bump to vagrant 2.3, the previous two (#219237, #225136) having stalled because of the darwin breakage.

@jerith666
Copy link
Contributor Author

Closing in favor of #225136, which has the most discussion.

@jerith666 jerith666 closed this Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerith666 @wegank @risicle