Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUXEDO Pulse 15 - Gen2: init #755

Merged
merged 13 commits into from
Oct 23, 2023
Merged

Conversation

trueNAHO
Copy link
Member

@trueNAHO trueNAHO commented Oct 9, 2023

Description of changes

Add NixOS hardware configuration for TUXEDO Pulse 15 - Gen2.

Question

Is it possible to replace the current udev rule in 1e70de2 with pure Nix by writing 0 to /sys/bus/pci/devices/$kernel/d3cold_allowed?

Things done
  • Tested the changes in your own NixOS Configuration: trueNAHO/os@64dbd23.
  • Tested the changes end-to-end by using your fork of nixos-hardware and importing it via <nixos-hardware> or Flake input.

@trueNAHO trueNAHO requested a review from Mic92 October 11, 2023 16:47
@trueNAHO trueNAHO marked this pull request as draft October 16, 2023 13:57
trueNAHO added a commit to trueNAHO/os that referenced this pull request Oct 16, 2023
@trueNAHO trueNAHO marked this pull request as ready for review October 16, 2023 14:19
@trueNAHO
Copy link
Member Author

LGTM

@Mic92
Copy link
Member

Mic92 commented Oct 19, 2023

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2023

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Mic92
Copy link
Member

Mic92 commented Oct 23, 2023

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2023

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@trueNAHO needs to authorize modification on its head branch.

@Mic92
Copy link
Member

Mic92 commented Oct 23, 2023

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2023

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 80d98a7

@mergify mergify bot merged commit 80d98a7 into NixOS:master Oct 23, 2023
3 checks passed
trueNAHO added a commit to trueNAHO/os that referenced this pull request Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants