Skip to content

Conversation

fidgetingbits
Copy link
Contributor

Description of changes

While working on #1535 I noticed there was a missing Dell entry, which got me looking for other missing entries. This adds all the other ones I found, as well as fixing up a couple typos in existing entries, and some table reformatting.

This was done by just manually going through results from for FILE in $(fd default.nix); do if \! rg $(dirname ${FILE}) README.md >/dev/null; then echo ${FILE} missing; fi; done | rg -v common and seeing which results were legitimately missing

I think I caught all of the real missing ones. While reviewing the raw table I decided to properly align most columns so that it's easier to edit/read.

Can do git diff -w to see the real non-alignment changes, which to summarize are:

Added:

  • Kobol Helios 4
  • Lenovo Legion Slim 5
  • Malibal Aon S1
  • Milk-V Pioneer
  • Olimex TERES-I

Fixed:

  • Framework 12th Gen Intel Core
  • HP Probook 440G5
Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@Mic92 Mic92 added this pull request to the merge queue Sep 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 1, 2025
@Mic92
Copy link
Member

Mic92 commented Sep 3, 2025

Oh, Looks like something else raced your pull request.

@fidgetingbits
Copy link
Contributor Author

Thanks for the ping @Mic92. Rebased with the #1601 changes taken into account.

@Mic92 Mic92 added this pull request to the merge queue Sep 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 30, 2025
@fidgetingbits fidgetingbits force-pushed the missing-readme-entries branch from 07f03c3 to 0257a0a Compare October 1, 2025 09:10
@fidgetingbits
Copy link
Contributor Author

Fixed the latest merge conflicts again.

@0x4A6F 0x4A6F added this pull request to the merge queue Oct 4, 2025
Merged via the queue into NixOS:master with commit 3441b52 Oct 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants