feat(nvidia-prime): automatic battery-saver specialisation #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables a boot option that switches off NVIDIA GPU. Allows for battery saving. @moduon MT-9339
yajo
force-pushed
the
nvidia-battery-saver
branch
from
5808a05 to
a807913
Compare
| enable = lib.mkOverride 990 true; | ||
| enableOffloadCmd = lib.mkIf config.hardware.nvidia.prime.offload.enable true; # Provides `nvidia-offload` command. | ||
| }; | ||
| # Hardware should specify the bus ID for intel/nvidia devices |
There was a problem hiding this comment.
Just like here: https://github.com/NixOS/nixos-hardware/pull/1413/files#diff-0fd91ddb6f4a0caed91c46e554f84c36da109e5b30a68655b45fab12058ebf7fR21
Would you prefer if this were an assertion?
FWIW this comment was already here.
There was a problem hiding this comment.
Yeah, would probably be nice if we asserted this so that it isn't forgotten.
Co-authored-by: Sandro <[email protected]>
|
IMHO this should be ready to merge. |
| enable = lib.mkOverride 990 true; | ||
| enableOffloadCmd = lib.mkIf config.hardware.nvidia.prime.offload.enable true; # Provides `nvidia-offload` command. | ||
| options = { | ||
| hardware.nvidia.primeBatterySaverSpecialisation = lib.mkEnableOption "Configure a specialisation which turns on NVIDIA Prime battery saver"; |
There was a problem hiding this comment.
Suggested change
| hardware.nvidia.primeBatterySaverSpecialisation = lib.mkEnableOption "Configure a specialisation which turns on NVIDIA Prime battery saver"; | |
| hardware.nvidia.primeBatterySaverSpecialisation = lib.mkEnableOption "configure a specialisation which turns on NVIDIA Prime battery saver"; |
otherwise the generated option will be named with a capital letter in a random position.
Comment on lines
+27
to
+29
| hardware.nvidia.prime.offload.enable = lib.mkForce false; | ||
| hardware.nvidia.powerManagement.enable = lib.mkForce false; | ||
| hardware.nvidia.powerManagement.finegrained = lib.mkForce false; |
There was a problem hiding this comment.
Suggested change
| hardware.nvidia.prime.offload.enable = lib.mkForce false; | |
| hardware.nvidia.powerManagement.enable = lib.mkForce false; | |
| hardware.nvidia.powerManagement.finegrained = lib.mkForce false; | |
| hardware.nvidia = { | |
| prime.offload.enable = lib.mkForce false; | |
| powerManagement = { | |
| enable = lib.mkForce false; | |
| finegrained = lib.mkForce false; | |
| }; | |
| }; |
but only a nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a boot option that switches off NVIDIA GPU. Allows for battery saving.
@moduon MT-9339
Description of changes
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input