Skip to content

Add Dell Inspiron 7559 and corresponding Skylake architecture #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

ccritter
Copy link
Contributor

@ccritter ccritter commented Feb 25, 2025

Description of changes
  • Adds Skylake CPU/GPU config
    • Verified support with vainfo and on Firefox + Chrome hardware acceleration
  • Adds Inspiron 7559 entries
    • Uses Nvidia Prime with offloading for support between the onboard and discrete GPU
    • Notes on some optional configuration in the README
    • Tested on fresh NixOS install using Flakes and Plasma DE
Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@ccritter ccritter mentioned this pull request Feb 25, 2025
@ccritter
Copy link
Contributor Author

ccritter commented Feb 25, 2025

Shoot, I only just now saw that new common modules are no longer accepted in favor of #992 for upstreaming to NixOS. To be honest, don't really know what that would involve, or what that would mean for this 7559 entry and the common modules it's pointing to. Any documentation for that process?

@JohnRTitor JohnRTitor requested a review from Mic92 February 27, 2025 08:48
@Mic92
Copy link
Member

Mic92 commented Mar 7, 2025

Shoot, I only just now saw that new common modules are no longer accepted in favor of #992 for upstreaming to NixOS. To be honest, don't really know what that would involve, or what that would mean for this 7559 entry and the common modules it's pointing to. Any documentation for that process?

We still add new common modules, but we no longer export them in the flake.nix as they are not part of the public interface and therefore users should not rely on them being present.

@Mic92
Copy link
Member

Mic92 commented Mar 7, 2025

@mergify queue

Copy link
Contributor

mergify bot commented Mar 7, 2025

queue

🛑 The pull request has been removed from the queue default

The pull request #1396 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Mic92
Copy link
Member

Mic92 commented Mar 7, 2025

@mergify refresh

Copy link
Contributor

mergify bot commented Mar 7, 2025

refresh

✅ Pull request refreshed

@Mic92
Copy link
Member

Mic92 commented Mar 7, 2025

@mergify queue

Copy link
Contributor

mergify bot commented Mar 7, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 5335d43

mergify bot added a commit that referenced this pull request Mar 7, 2025
@mergify mergify bot merged commit 5335d43 into NixOS:master Mar 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants