Adding the Legion Pro 7 16IRX9H model #1128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from the 16IRX8H, but I am still having issues with WiFi and sound (to be resolved). Ref.: https://psref.lenovo.com/Product/Legion/Legion_Pro_7_16IRX9H
felipelalli
changed the title
Mic92
reviewed
Sep 18, 2024
Comment on lines
+15
to
+16
| boot.initrd.kernelModules = ["nvidia"]; | ||
| boot.extraModulePackages = [config.boot.kernelPackages.lenovo-legion-module config.boot.kernelPackages.nvidia_x11]; |
There was a problem hiding this comment.
the legion module is needed, but the rest should be already covered by the nvidia module.
There was a problem hiding this comment.
Suggested change
| boot.initrd.kernelModules = ["nvidia"]; | |
| boot.extraModulePackages = [config.boot.kernelPackages.lenovo-legion-module config.boot.kernelPackages.nvidia_x11]; | |
| boot.extraModulePackages = [config.boot.kernelPackages.lenovo-legion-module]; |
Mic92
reviewed
Sep 18, 2024
|
|
||
| hardware = { | ||
| nvidia = { | ||
| modesetting.enable = lib.mkDefault true; |
There was a problem hiding this comment.
Already enabled.
Suggested change
| modesetting.enable = lib.mkDefault true; |
|
@Mic92 I just copied it from https://github.com/NixOS/nixos-hardware/blob/master/lenovo/legion/16irx8h/default.nix is that wrong too? Should I fix it too in this same PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, I simply copied it from the 16IRX8H, but I am still having issues with WiFi and sound (to be resolved).
Ref.: https://psref.lenovo.com/Product/Legion/Legion_Pro_7_16IRX9H
Description of changes
Adding the Legion Pro 7 16IRX9H model, copy/paste from 16IRX8H.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input