apple-t2: remove ifd and cleanup drv #1127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This was originally going to be a PR fixing all IFDs found in nixos-hardware, but I could only find two:
apple-t2 was easily fixable, and in the process the drv itself was cleaned up, but toshiba-swanky is a bit more problematic due to the use of system.replaceRuntimeDependencies, which is by nature impure and IFD.
Given the above, this PR has been adjusted to only fix up the apple-t2 IFD.
Note: Testing for the IFDs was iterative and I am very confident I did not miss any. It was done through iterative generation of nixos configurations that imported each module and set relevant setting to allow evaluation at minimum.
Things done
nixos-hardware
andimporting it via
<nixos-hardware>
or Flake input