libexpr: diagnostics framework & error recovery basics #9119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an NFC PR that splits epilogue & prologue from parser. As mentioned in NixOS#8812, we can add static checking tools & auto formatting for these files, but if it is written .y directly, the clang parser cannot understand the code is actually "C++".
This PR contains no functioanl change, there are bunch of suggesstions by clang-tidy in the file and there are fixes available. Including: - 0 -> nullptr - use `auto` for iterator types - sort `#include`s - closing namespace comment - use `.empty()` instead of comparing it with empty object - use `auto` if it the type is apparently specified (e.g. `new Type`) - add const specifier or `&` to improve readability
inclyc
force-pushed
the
users/inclyc/support-diag
branch
from
c84be50 to
50bf588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is an initial support for warning & diagnostics (it is really large so I pushed it here for review). We talked about Nix language versioning in NixOS/rfcs#137 , and this PR brings some deprecate warnings for nix parser.
Previously we are just throwing exceptions, but it may not work for encountered some syntax we want to give a "warning" to the user, so I deferred the throwing after parsing.
Context
Depends-on: #9089
Partially-addresses: #8584
Impl strategy
Adding a macro-based framework that allow many kinds of diagnostic definition & formatting
Priorities
Add 👍 to pull requests you find important.