nix: add nix flake root
#8486
nix: add nix flake root
#8486
Conversation
src/nix/flake.cc
Outdated
| addFlag({ | ||
| .longName = "as-ref", | ||
| .shortName = 'r', | ||
| .description = "Show flake root as a normalized flake ref.", |
There was a problem hiding this comment.
What is a normalized flake ref?
There was a problem hiding this comment.
Something like git+path:/path/to/flake/folder instead of /path/to/flake/folder
There was a problem hiding this comment.
The word "normalized" never shows up in the manual at all, and flakeref is written without a space. Maybe "Show the root as a flakeref in URL-like representation." This way people can check in the manual what that actually means.
src/nix/flake.cc
Outdated
|
|
||
| std::string description() override | ||
| { | ||
| return "get flake root"; |
There was a problem hiding this comment.
Should this be something like "get the root directory of a flake"? Not entirely clear what "flake root" means.
| int slashIndex = rootRef.find('/'); | ||
| while (rootRef[slashIndex + 1] == '/') { | ||
| slashIndex++; | ||
| } | ||
| rootRef = rootRef.substr(slashIndex); |
There was a problem hiding this comment.
Not clear to me what this does...
There was a problem hiding this comment.
it just eats out that flake specific part
|
Does it look for the flake directory or for the flake root? (And did we settle on those terms?)
To be clear this command is not a solution for that issue, but I appreciate the link. |
Nix already has a logic to go up levels and find the flake.nix. This subcommand just exposes what it finds. Signed-off-by: lucasew <[email protected]>
Motivation
Nix already has a logic to go up levels and find the flake.nix. This subcommand just exposes what it finds.
Context
Implementation guide for #8034
Consumes logic introduced in #5720
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.