Skip to content

RFC 110: Add "inherit-as-list" language construct #5402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

RFC 110: Add "inherit-as-list" language construct #5402

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a22abd
RFC 110: Add "inherit-as-list" language construct
r-burns Oct 18, 2021
ea2bb4e
Revert "RFC 110: Add "inherit-as-list" language construct"
r-burns Oct 19, 2021
a297926
New implementation, more consistent with existing inherit syntax
r-burns Oct 19, 2021
e3dbc74
Simplify desugared form
r-burns Oct 20, 2021
a606861
Revise to list-like syntax proposed by Synthetica9
r-burns Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/libexpr/parser.y
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,16 @@ expr_select
{ $$ = new ExprSelect(CUR_POS, $1, *$3, 0); }
| expr_simple '.' attrpath OR_KW expr_select
{ $$ = new ExprSelect(CUR_POS, $1, *$3, $5); }
| expr_simple '.' '[' attrs ']'
{
auto lst = new ExprList;
lst->elems.reserve($4->size());
for (auto & i : *$4) {
/* !!! Should ensure sharing of the expression in $4. */
lst->elems.push_back(new ExprSelect(makeCurPos(@4, data), $1, i.symbol));
}
$$ = lst;
}
| /* Backwards compatibility: because Nixpkgs has a rarely used
function named ‘or’, allow stuff like ‘map or [...]’. */
expr_simple OR_KW
Expand Down