Repository navigation
[Backport 2.35-maintenance] Fix incorrectly reported bytes freed for local-overlay-store - #16630
Merged
internal-nix-ci[bot] merged 1 commit intoOct 17, 2026
Conversation
Today the bytesFreed variable is uninitialized. If no bytes are freed, the number of bytes reported is incorrect. The full behavior of this issue is documented in issue #16269, that I was able to independently reproduce. To address this, we assign bytesFreed = 0 at initialization, which is consistent with the implementation at the other call sites of deleteStorePath such as https://github.com/NixOS/nix/blob/a9f38ea0ee89f550616f342386f45e896f4abd18/src/libstore/local-overlay-store.cc#L253. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 094819a)
internal-nix-ci
Bot
requested review from
Ericson2314 and
edolstra
as code owners
October 17, 2026 22:59
github-actions
Bot
added
the
store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic backport to
2.35-maintenance, triggered by a label in #16616.