Repository navigation
[Backport 2.32-maintenance] libutil: link ntdll on Windows - #16605
Merged
Merged
Conversation
`windows/file-system-at.cc` calls `NtCreateFile` and `RtlNtStatusToDosError`, which live in `ntdll`, but nothing asked for that library. It only happened to link anyway with the GCC from Nixpkgs, because that one was configured with `--enable-threads=mcf`, whose spec appends `-lmcfgthread -lkernel32 -lntdll` for the sake of mcfgthreads. A toolchain that does not do that fails with undefined references to both symbols. Now we make sure to link it, and put it in the *.pc files. This follows the precedent set with `ws2_32`. Assisted-By: Claude Code (Claude Opus 5) (cherry picked from commit 4b247ec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic backport to
2.32-maintenance, triggered by a label in #16306.