log builder uid if building locally #14654
Open
+34
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It might be helpful to know the assigned builder for a drv. I talk about this more in #14639, but my specific usecase is tying processes to a builder for a nix task monitor. But I think this could also be helpful when debugging (for example, if a builder locks up and you want to figure out which derivation it was building)
Context
The context is also primarily #14639. This change feels relatively small to me, and shouldn't make much of a difference unless someone is parsing the log output.
In terms of testing I ran the check phase. Two tests fail, but they also seem to fail prior to this change (?)
I also ran the daemon and ran some local builds on both macos and nixos. Both targets printed the builder uid. But, I wasn't able to test a remote builder
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.