perf(libstore/derivation-builder): pre-compute outputGraph for linear complexity #14540
+57
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovesegfault
force-pushed
the
pre-compute-outputgraph
branch
from
ebc1008 to
7b7e555
Compare
Ericson2314
force-pushed
the
pre-compute-outputgraph
branch
from
7b7e555 to
4b5a1ca
Compare
Ericson2314
approved these changes
Nov 25, 2025
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
OK let me know what you think @lovesegfault. The original code from @Ma27 unnecessarily made its own data structures when we already had a graph data structure on hand. If you go commit-by-commit and disable whitespace, it should be fairly easy to read.
Member
Author
|
Nice, thanks @Ericson2314! This looks good to me :) |
Ericson2314
approved these changes
Nov 26, 2025
xokdvium
requested changes
Nov 26, 2025
xokdvium
reviewed
Nov 26, 2025
xokdvium
reviewed
Nov 26, 2025
Ericson2314
force-pushed
the
pre-compute-outputgraph
branch
from
e533c4c to
5308f10
Compare
github-actions
bot
added
the
store
Member
|
@xokdvium how is it now, with the first commit ensuring that making things by reference actually gives us value? |
xokdvium
reviewed
Nov 28, 2025
xokdvium
reviewed
Nov 28, 2025
xokdvium
approved these changes
Nov 28, 2025
- No `std::function` overhead - Don't copy if not necessary Co-authored-by: Sergei Zimmerman <[email protected]>
… complexity Build the inverse of `scratchOuputs` before running topoSort, avoiding quadratic complexity when determining which outputs reference each other. This fixes the FIXME comment about building the inverted map up front. Inspired by Lix commit 10c04ce84 / Change Id Ibdd46e7b2e895bfeeebc173046d1297b41998181, but ended up being completely different code. Co-Authored-By: Maximilian Bosch <[email protected]> Co-Authored-By: Bernardo Meurer Costa <[email protected]>
We can precompute the exact information we need for topo sorting and store it in `PerhapsNeedToRegister`. Depending on how `topoSort` works, this is easy a performance improvement or just completely harmless. Co-Authored-By: Bernardo Meurer Costa <[email protected]>
Ericson2314
force-pushed
the
pre-compute-outputgraph
branch
from
4810718 to
c33b2c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Build the output reference graph and inverse output map before running
topoSort, avoiding quadratic complexity when determining which outputs
reference each other. This fixes the FIXME comment about building the
inverted map up front.
The outputGraph (StorePath → StorePathSet) maps each output to its
references, and will be reused in future commits to generate detailed
cycle error messages showing which files contain problematic references.
Adapted from Lix commit 10c04ce84.
Change-Id: Ibdd46e7b2e895bfeeebc173046d1297b41998181
Co-Authored-By: Maximilian Bosch [email protected]
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.