Expose flake directory to nix fmt as NIX_FLAKE_DIR env var
#13143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
new-cli
edolstra
reviewed
May 7, 2025
jfly
force-pushed
the
issue-8034-nix-fmt
branch
3 times, most recently
from
5caf343 to
262938d
Compare
jfly
changed the title
nix fmt as FLAKE_DIR env varnix fmt as NIX_FLAKE_DIR env var
jfly
changed the title
nix fmt as NIX_FLAKE_DIR env varnix fmt as NIX_FLAKE_DIR env var
jfly
commented
May 7, 2025
This type was defined in `DerivationBuilderImpl`, but it could live happily in `environment-variables.h`, so I put it there.
This was discussed in NixOS#8034. I personally like `NIX_FLAKE_DIR`, which hopefully avoids some ambiguity around with subflakes. I only implemented this for `nix fmt` because it doesn't let you point at a flake not on your filesystem.
You need an `extern` dance to access `environ`, and apparently `execvpe` doesn't exist on macOS :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed in #8034. I personally like
NIX_FLAKE_DIR, which hopefully avoids some ambiguity around with subflakes.I only implemented this for
nix fmtbecause it doesn't let you point at a flake not on your filesystem.Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.