-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
nix registry pin: Mark the resulting registry entry as exact #12581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Since the resulting target flakeref contains attributes like "lastModified" or "narHash", it's not suitable for overriding. This led to errors like $ nix build nixpkgs/24.05#hello error: 'lastModified' attribute mismatch in input 'github:NixOS/nixpkgs/63dacb46bf939521bdc93981b4cbb7ecb58427a0', expected 1728538411, got 1717179513 after doing `nix registry pin nixpkgs`.
|
What is exact? It's not documented in the manual or on the C++ field. |
|
It means that the registry entry is only used to rewrite the given flakeref if it's exactly equal to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could add a test for this, it looks good to me.
|
Added a test in #13229 |
Motivation
Since the resulting target flakeref contains attributes like
lastModifiedornarHash, it's not suitable for overriding. This led to errors likeafter doing
nix registry pin nixpkgs.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.