-
-
Couldn't load subscription status.
- Fork 323
hydra-eval-jobset: allow attributes other than checks/hydraJobs #1518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| "or flake.checks " . | ||
| "or (throw \"flake '$flakeRef' does not provide any Hydra jobs or checks\")"; | ||
| my $nix_expr; | ||
| my ($ref, $attr) = split '#', $flakeRef, 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to switch this over to --select: nix-community/nix-eval-jobs@5738c86
otherwise it's impure eval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course we already had this issue before hand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, for now I can cherry pick this and I can look at --select after this repo is updated to 2.31.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to get the ci fixed for 2.31 asap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind carrying the patch for a while so don't rush the work on 2.31 unless you've got other reasons.
| . ":\n" . ($stderr ? decode("utf-8", $stderr) : "(no output)\n") | ||
| if $res; | ||
| $flakeRef = decode_json($json)->{'url'}; | ||
| $ref = decode_json($json)->{'url'}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this PR the evaluator stops picking up new changes.
After testing I found out that this line should stay $flakeRef = decode_json($json)->{'url'};.
I'd like to be able to build different attrs from the same flake.