Skip to content

separate error handling for account creation and profile update in s… #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nitya-003 merged 1 commit into from
Jul 24, 2026
Merged

separate error handling for account creation and profile update in s… #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 27 additions & 19 deletions frontend/components/signupform.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,28 +27,36 @@ export default function SignupForm() {
const onSubmit = async (data: SignupFormData) => {
setServerError(null);
const toastId = toast.loading("Creating account...");
let userCredential;
try {
const userCredential = await createUserWithEmailAndPassword(auth, data.email, data.password);

// Update the user's profile with their name
await updateProfile(userCredential.user, {
displayName: data.name
});

toast.dismiss(toastId);
toast.success("Account Created!", {
description: "Welcome to InnerHue.",
});

router.push("/");
userCredential = await createUserWithEmailAndPassword(
auth,
data.email,
data.password
);
} catch (error: unknown) {
const message = error instanceof Error ? error.message : "Something went wrong.";
toast.dismiss(toastId);
setServerError(message);
toast.error("Signup failed", {
description: message,
});
const message =
error instanceof Error ? error.message : "Something went wrong." ;
toast.dismiss(toastId);
setServerError(message) ;
toast.error("Signup failed", {
description: message,
});
return ;// stop here — don't try updateProfile if account creation failed
}
try {
await updateProfile(userCredential.user, {
displayName: data.name,
});
} catch (profileError) {
console.error("Failed to set display name:", profileError) ;
}

toast.dismiss(toastId);
toast.success("Account Created!", {
description: "Welcome to InnerHue.",
});
router.push("/");
};

return (
Expand Down
Loading