Bump ureq to 3.0.0-rc2 #35
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And it would also make the TLS configuration for the tests much easier, so I’m in favor of updating. |
|
No it would not, on the opposite it would make it more complex. This currently fails because when disabling TLS it says to the server that it does not support any Signature scheme which leads to an error :( And in the pkcs11 module we would still need some custom TLS config. But at least now it will not depend on a semver hazard. |
sosthene-nitrokey
force-pushed
the
ureq-v3.0
branch
from
0cf5f3a to
09fdb6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a breaking change. Benefits: some of the feature we needed to improve the reliability of the pkcs11 module were only available in our fork. This would allow us to use the upstream version.