fix(android): replace getClass() with javaClassStatic() #225
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity Android 8+ restricts the usage of getClass() in certain cases, causing crashes. This commit replaces `_javaPart->getClass()` with `_javaPart->javaClassStatic()`, which is a more stable approach. This change is based on a similar fix in react-native-nitro: mrousavy/nitro#582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a crash on Android 8+ caused by using
_javaPart->getClass()to retrieve the Java class.
The correct approach is to use
_javaPart->javaClassStatic(),which avoids compatibility issues.
Changes
_javaPart->getClass()with_javaPart->javaClassStatic()fix: Replace
getClass()withjavaClassStatic()mrousavy/nitro#582Why?
On certain devices,
getClass()is not allowed and leads to crasheswhen trying to access JNI methods. This update ensures better compatibility.
Test Plan
openPicker()and other related functions work as expected.