Dev #2
Dev #2
Conversation
| def read_lines(file): | ||
| lines = [] | ||
| ip = '127.0.0.1' | ||
| f = open(file, 'r') |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Problem
This line of code might contain a resource leak. Resource leaks can cause your system to slow down or crash.
Fix
Consider closing the following resource: f. The resource is allocated by call builtins.open. Execution paths that do not contain closure statements were detected. To prevent this resource leak, close f in a try-finally block or declare it using a with statement.
More info
View details about the with statement in the Python developer's guide (external link).
|
|
||
| def paginated_ddb_scan_responses(): | ||
| ddb = boto3.client('dynamodb') | ||
| response = ddb.scan(TableName='test') |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
The API method scan returns paginated results instead of all results. Consider using the pagination API or checking one of the following keys in the response to verify that all results were returned: ExclusiveStartKey, IsTruncated, LastEvaluatedKey, NextToken.
CodeGuru demo