Skip to content

Moving from xUnit v2 to v3 #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sadukie merged 5 commits into from
Jun 11, 2025
Merged

Moving from xUnit v2 to v3 #224

sadukie merged 5 commits into from
Jun 11, 2025

Conversation

@sadukie
Copy link
Contributor

@sadukie sadukie commented Jun 11, 2025

Closes #223

  • Updates xUnit references to latest stable xunit.v3 version
  • Removes references to Xunit.Abstractions
  • Updates CancellationToken handling with the xUnit analyzer guidance - xUnit1051
    • Replaces default values of Cancellation to either Arg.Any<CancellationToken>() or TestContext.Current.CancellationToken, depending on the code situation
    • No more CancellationToken.None - Thanks to @sdepouw for this call-out!

@sadukie sadukie linked an issue Jun 11, 2025 that may be closed by this pull request
Update to xUnit v3 #223
Closed
KyleMcMaster
KyleMcMaster approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@KyleMcMaster KyleMcMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions
Copy link

github-actions bot commented Jun 11, 2025

Code Coverage

Package Line Rate Branch Rate Complexity Health
Infrastructure 4% 14% 82 ❌
BlazorAdmin 0% 0% 512 ❌
UnitTests 12% 0% 132 ❌
eShopWeb.AspireServiceDefaults 0% 0% 8 ❌
ApplicationCore 32% 27% 116 ❌
Web 0% 0% 749 ❌
BlazorShared 0% 0% 48 ❌
Summary 4% (273 / 7086) 1% (11 / 897) 1647 ❌

@sadukie sadukie merged commit bcd43e3 into main Jun 11, 2025
2 checks passed
@sadukie sadukie deleted the sadukie/xunit-to-v3 branch June 11, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KyleMcMaster KyleMcMaster KyleMcMaster approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to xUnit v3

3 participants

@sadukie @KyleMcMaster