Skip to content

[ANDROID][SDK] Add get phoneme support#178

Merged
void-memories merged 24 commits into
NimbleEdge:mainfrom
void-memories:naman/android/espeak-decoupling
Aug 12, 2025
Merged

[ANDROID][SDK] Add get phoneme support#178
void-memories merged 24 commits into
NimbleEdge:mainfrom
void-memories:naman/android/espeak-decoupling

Conversation

@void-memories
Copy link
Copy Markdown
Contributor

Description

Please provide a description of this PR.

Fixes # (issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Has user-facing changes. This may include API or behavior changes and performance improvements, etc

Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
…k-decoupling

Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
@void-memories void-memories requested review from a team, jpuneet and nrjpoddar as code owners August 8, 2025 10:11
jpuneet added 10 commits August 11, 2025 16:30
Signed-off-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
Signed-off-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
Signed-off-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
Signed-off-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
Signed-off-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
Signed-off-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
Signed-off-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
Signed-off-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
Signed-off-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
Signed-off-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
jpuneet
jpuneet previously approved these changes Aug 11, 2025
@jpuneet
Copy link
Copy Markdown
Contributor

jpuneet commented Aug 11, 2025

Issue

::get_phonemes(...) is now defined for platform/android and platform/ios, but not for platform/unix. So, the platform/unix build is failing.

Fix

Change

#ifdef IOS
...
#endif  // IOS

to

#if defined(__ANDROID__) || defined(IOS)
...
#endif  // defined(__ANDROID__) || defined(IOS)

Signed-off-by: Puneet Jindal <puneetjindal.1988@gmail.com>
Signed-off-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
jpuneet
jpuneet previously approved these changes Aug 11, 2025
Comment thread coreruntime/nimblenet/data_variable/include/data_variable_enums.hpp
@void-memories
Copy link
Copy Markdown
Contributor Author

Issue

::get_phonemes(...) is now defined for platform/android and platform/ios, but not for platform/unix. So, the platform/unix build is failing.

Fix

Change

#ifdef IOS
...
#endif  // IOS

to

#if defined(__ANDROID__) || defined(IOS)
...
#endif  // defined(__ANDROID__) || defined(IOS)

@jpuneet Can I write a function in linux/client.cpp that throws "Function not implemented" instead?

@jpuneet
Copy link
Copy Markdown
Contributor

jpuneet commented Aug 12, 2025

@void-memories, go ahead.

Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
@void-memories void-memories added the ready-for-test This label triggers android instrumentation tests label Aug 12, 2025
@void-memories void-memories merged commit 147c880 into NimbleEdge:main Aug 12, 2025
13 checks passed
@void-memories void-memories deleted the naman/android/espeak-decoupling branch August 12, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-test This label triggers android instrumentation tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants