[ANDROID][SDK] Fix asset copy logic + Add android tests + Code cleanup#114
Merged
void-memories merged 6 commits intoJul 15, 2025
Merged
Conversation
nrjpoddar
reviewed
Jul 14, 2025
Contributor
nrjpoddar
left a comment
nrjpoddar
left a comment
There was a problem hiding this comment.
Overall LGTM but I will let @Arpit2601 review in more details
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
void-memories
force-pushed
the
naman/android/fix/asset-folder-copy
branch
from
60bcf15 to
e51c7b0
Compare
Arpit2601
reviewed
Jul 14, 2025
jpuneet
reviewed
Jul 14, 2025
jpuneet
reviewed
Jul 14, 2025
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
jpuneet
reviewed
Jul 15, 2025
jpuneet
approved these changes
Jul 15, 2025
jpuneet
approved these changes
Jul 15, 2025
nrjpoddar
approved these changes
Jul 15, 2025
Contributor
|
Addresses #99 |
Suryansh1191
pushed a commit
to Suryansh1191/deliteAI-public
that referenced
this pull request
Jul 21, 2025
NimbleEdge#114) * code cleanup * address pr comments * make copy asset tests generic * cosmetics --------- Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai> Co-authored-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai> Signed-off-by: Suryansh Bisen <suryansh.bisen@nimbleedgehq.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a description of this PR.
Fixes # (issue)
Checklist: