W1: remove nb__manage_app#274
Merged
Merged
Conversation
* feat(stage-2/identity-apps W1): remove nb__manage_app Rip out the conversational bundle install/uninstall/configure chat tool. It was non-functional today, and conversational workspace mutation deserves real design later (single tool, explicit workspace param, per-call admin auth) — so remove rather than redesign. The install lifecycle, CLI, catalog, and connector config UI are unaffected. - system-tools.ts: drop the manage_app tool def + the configureBundle / install/uninstallBundleFromWorkspaceViaCtx helpers and ManageBundleContext. Keep the exported resolveBundleServerName (still consumed by uninstall). gate/manageBundleCtx become reserved positional slots (_gate / _manageBundleCtx) so every call site's arity holds. - runtime.ts: drop the manageBundleCtx construction + call-site arg. - features.ts / privilege.ts: drop the manage_app feature-map entries and privilege rule. bundleManagement flag kept as a reserved operator knob. - bootstrap.md / skill-authoring.md: install + credential setup now happen in the Apps catalog / CLI, not chat. - CLI deprecation strings + stale comments repointed off manage_app. - Tests: delete the two manage_app-only integration files; repoint the privilege/audit/visibility tests to the surviving skills__create gate; assert manage_app is absent. * fix(W1): delete dead uninstall helpers orphaned by manage_app removal QA review caught that resolveBundleServerName (system-tools.ts) and uninstallBundleFromWorkspace (workspace-ops.ts) had exactly one caller — the uninstallBundleFromWorkspaceViaCtx helper this PR already removed — so both are dead production code after W1, not "consumed by the uninstall path" as the PR body wrongly claimed. The canonical uninstall is BundleLifecycleManager.uninstall(), which is self-contained: it resolves the server name via its instance map, runs the protected check, removes the source, clears workspace credentials, and unregisters placements/config/automations. It never touched either helper. - Delete both functions and their two unit tests (workspace-ops-uninstall, workspace-uninstall-credentials). Those tests only pinned dead code; the live behaviors are covered against lifecycle.uninstall() in lifecycle.test.ts (protected reject, credential file removal + sibling untouched, data-dir preservation, idempotent no-op). - installBundleInWorkspace stays — it's still live (connector install). - Drop the stale comments that referenced the deleted sibling and a non-existent "catalog/connector uninstall" caller. --------- Co-authored-by: Mathew Goldsborough <1759329+mgoldsborough@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands #273, which was merged into
stage-2/main(already squash-merged to main via #272) and got stranded — its W1 commit never reachedmain.This is a cherry-pick of
eab163aonto currentmain. The cherry-pick applied with zero conflicts and the resulting tree is byte-identical to the state that passed CI on #273.Removes the conversational
nb__manage_appinstall/uninstall/configure chat tool (non-functional today; conversational workspace mutation deserves real design later). Install lifecycle, CLI, catalog, and connector config UI are unaffected.