Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt code to work with release 15.10.2024 #26

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

0xAleksaOpacic
Copy link
Collaborator

@0xAleksaOpacic 0xAleksaOpacic commented Oct 18, 2024

Description

This PR fixes all issues introduces issues introduces with latest release 15.10.2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Test

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
0xAleksaOpacic Aleksa Opacic
Copy link

@Zerg1996 Zerg1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was your compilation successful?

DeclarationError: Identifier not found or not unique.
  --> contracts/interfaces/IUniswapV2Pair.sol:27:48:
   |
27 |     function token0Id() external view returns (CurrencyId);
   |                                                ^^^^^^^^^^


Error HH600: Compilation failed

contracts/UniswapV2Pair.sol Outdated Show resolved Hide resolved
package.json Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to remove --network nil also in this file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done f58b583

Copy link

@Zerg1996 Zerg1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compile problem was on my side, I didn't update npm packages.

Verified

This commit was signed with the committer’s verified signature.
0xAleksaOpacic Aleksa Opacic

Verified

This commit was signed with the committer’s verified signature.
0xAleksaOpacic Aleksa Opacic
@0xAleksaOpacic 0xAleksaOpacic merged commit dbd9678 into main Oct 21, 2024
2 checks passed
@0xAleksaOpacic 0xAleksaOpacic deleted the fix_changes_release_15_10_2024 branch October 21, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants