Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate crypto3 step #97

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Separate crypto3 step #97

merged 9 commits into from
Oct 30, 2024

Conversation

AndreyMlashkin
Copy link
Collaborator

@AndreyMlashkin AndreyMlashkin commented Oct 18, 2024 •
edited
Loading

  • separate crypto3, as it requires a limit for cores;
  • fix building crypto3 two times

akokoshn
akokoshn reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@akokoshn akokoshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason make crypto3 check separate step?

.github/workflows/clang-linux-nix-check.yml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Clang Test Results

  153 files  ±0    153 suites  ±0   10m 42s ⏱️ -1s
3 200 tests ±0  3 194 ✅ ±0  6 💤 ±0  0 ❌ ±0 
3 270 runs  ±0  3 264 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit d479ae9. ± Comparison against base commit 8c14f09.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Gcc Test Results

  153 files  ± 0    153 suites  ±0   11m 38s ⏱️ -1s
3 200 tests + 2  3 194 ✅ + 2  6 💤 ±0  0 ❌ ±0 
3 270 runs   - 97  3 264 ✅  - 97  6 💤 ±0  0 ❌ ±0 

Results for commit d479ae9. ± Comparison against base commit 8c14f09.

This pull request removes 4 and adds 6 tests. Note that renamed tests count towards both. 
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test

pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4

♻️ This comment has been updated with latest results.

@AndreyMlashkin AndreyMlashkin requested a review from x-mass October 21, 2024 11:43
akokoshn
akokoshn reviewed Oct 21, 2024
View reviewed changes
crypto3/cmake/CheckSSE.cmake Outdated Show resolved Hide resolved
crypto3.nix Show resolved Hide resolved
@akokoshn akokoshn requested a review from martun October 21, 2024 19:39
@AndreyMlashkin
Copy link
Collaborator Author

What is the reason make crypto3 check separate step?

We use 4 cores to compile crypto3 and all cores for the rest of the checks.
We have 4 cores limitatiom because of the OOM issue

@AndreyMlashkin AndreyMlashkin force-pushed the separate_crypto3_step branch 3 times, most recently from 640a0a2 to d3e5982 Compare October 30, 2024 10:12
akokoshn
akokoshn reviewed Oct 30, 2024
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
parallel-crypto3/CMakeLists.txt Outdated Show resolved Hide resolved
@AndreyMlashkin AndreyMlashkin merged commit 653cabf into master Oct 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x-mass x-mass x-mass left review comments

@akokoshn akokoshn akokoshn approved these changes

@martun martun Awaiting requested review from martun

Assignees

@AndreyMlashkin AndreyMlashkin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreyMlashkin @akokoshn @x-mass