Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

86 todos in algebra #88

Merged
merged 1 commit into from
Oct 29, 2024
Merged

86 todos in algebra #88

merged 1 commit into from
Oct 29, 2024

Conversation

vo-nil
Copy link
Contributor

@vo-nil vo-nil commented Oct 15, 2024 •
edited
Loading

This PR addresses TODOs in algebra code, including, but not limited to:
- handling errors from marshalling;
- removal of extended_integral_type from fields;
- final_exponentiation in pairings can fail when dealing with zero;
- updated type_traits system to handle types properly;
- fixed multiexp implementation and added tests for it;
- added documentation references to constants origins;
- removed old r1cs, ppzksnark code;
- excluded evm-assigner and zkevm-framework from builds as they are
deprecated and subject for removal;

@vo-nil vo-nil force-pushed the 86-todos-in-algebra branch 2 times, most recently from e3eff6c to 4f38a9b Compare October 17, 2024 11:35
@vo-nil vo-nil marked this pull request as ready for review October 18, 2024 12:56
@vo-nil vo-nil requested a review from martun October 18, 2024 12:56
@vo-nil vo-nil marked this pull request as draft October 21, 2024 06:16
@vo-nil vo-nil force-pushed the 86-todos-in-algebra branch from e2f5747 to 9304644 Compare October 22, 2024 07:39
@vo-nil vo-nil self-assigned this Oct 22, 2024
@vo-nil vo-nil force-pushed the 86-todos-in-algebra branch from 9e293de to cdf6ac2 Compare October 23, 2024 14:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Clang Test Results

  153 files  + 1    153 suites  +1   10m 25s ⏱️ -4s
3 198 tests +19  3 192 ✅ +19  6 💤 ±0  0 ❌ ±0 
3 367 runs  +19  3 361 ✅ +19  6 💤 ±0  0 ❌ ±0 

Results for commit 7c73911. ± Comparison against base commit 6572b08.

This pull request removes 2 and adds 21 tests. Note that renamed tests count towards both. 
fields_manual_tests ‑ field_operation_test_maxprime
r1cs_gg_ppzksnark_test_suite ‑ r1cs_gg_ppzksnark_basic_test

multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__alt_bn128_g1<254ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__jacobian_with_a4_0>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__alt_bn128_g2<254ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__jacobian_with_a4_0>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__bls12_g1<377ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__jacobian_with_a4_0>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__bls12_g1<381ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__jacobian_with_a4_0>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__bls12_g2<377ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__jacobian_with_a4_0>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__bls12_g2<381ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__jacobian_with_a4_0>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__mnt4_g1<298ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__projective>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__mnt4_g2<298ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__projective>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__mnt6_g1<298ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__projective>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__mnt6_g2<298ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__projective>>>
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

Gcc Test Results

  153 files  + 1    153 suites  +1   11m 18s ⏱️ -14s
3 200 tests +15  3 194 ✅ +15  6 💤 ±0  0 ❌ ±0 
3 270 runs  +15  3 264 ✅ +15  6 💤 ±0  0 ❌ ±0 

Results for commit 7c73911. ± Comparison against base commit 6572b08.

This pull request removes 6 and adds 21 tests. Note that renamed tests count towards both. 
fields_manual_tests ‑ field_operation_test_maxprime
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
r1cs_gg_ppzksnark_test_suite ‑ r1cs_gg_ppzksnark_basic_test

multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__alt_bn128_g1<254ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__jacobian_with_a4_0>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__alt_bn128_g2<254ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__jacobian_with_a4_0>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__bls12_g1<377ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__jacobian_with_a4_0>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__bls12_g1<381ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__jacobian_with_a4_0>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__bls12_g2<377ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__jacobian_with_a4_0>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__bls12_g2<381ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__jacobian_with_a4_0>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__mnt4_g1<298ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__projective>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__mnt4_g2<298ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__projective>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__mnt6_g1<298ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__projective>>>
multiexp_test ‑ multiexp_test<multiexp_test__multiexp_runner<nil__crypto3__algebra__curves__detail__mnt6_g2<298ul__nil__crypto3__algebra__curves__forms__short_weierstrass__nil__crypto3__algebra__curves__coordinates__projective>>>
…

♻️ This comment has been updated with latest results.

@vo-nil vo-nil force-pushed the 86-todos-in-algebra branch from 9a67a72 to 7c73911 Compare October 25, 2024 06:57
@vo-nil vo-nil marked this pull request as ready for review October 25, 2024 06:59
@vo-nil vo-nil requested a review from martun October 25, 2024 06:59
@vo-nil
This commit addresses TODOs in algebra code, including, but not limited
3252cc2 
to:
- handling errors from marshalling;
- removal of extended_integral_type from fields;
- final_exponentiation in pairings can fail when dealing with zero;
- updated type_traits system to handle types properly;
- fixed multiexp implementation and added tests for it;
- added documentation references to constants origins;
- removed old r1cs, ppzksnark code;
- excluded evm-assigner and zkevm-framework from builds as they are
  deprecated and subject for removal;
@vo-nil vo-nil force-pushed the 86-todos-in-algebra branch from 7c73911 to 3252cc2 Compare October 29, 2024 10:56
@martun martun self-requested a review October 29, 2024 10:59
@vo-nil vo-nil merged commit d3107ee into master Oct 29, 2024
6 checks passed
@vo-nil vo-nil deleted the 86-todos-in-algebra branch October 29, 2024 11:02
AndreyMlashkin pushed a commit that referenced this pull request Oct 30, 2024
@vo-nil @AndreyMlashkin
This commit addresses TODOs in algebra code, including, but not limit…
15aa408 
…ed (#88)

to:
- handling errors from marshalling;
- removal of extended_integral_type from fields;
- final_exponentiation in pairings can fail when dealing with zero;
- updated type_traits system to handle types properly;
- fixed multiexp implementation and added tests for it;
- added documentation references to constants origins;
- removed old r1cs, ppzksnark code;
- excluded evm-assigner and zkevm-framework from builds as they are
  deprecated and subject for removal;
akokoshn pushed a commit that referenced this pull request Oct 30, 2024
@vo-nil @akokoshn
This commit addresses TODOs in algebra code, including, but not limit…
89f25bf 
…ed (#88)

to:
- handling errors from marshalling;
- removal of extended_integral_type from fields;
- final_exponentiation in pairings can fail when dealing with zero;
- updated type_traits system to handle types properly;
- fixed multiexp implementation and added tests for it;
- added documentation references to constants origins;
- removed old r1cs, ppzksnark code;
- excluded evm-assigner and zkevm-framework from builds as they are
  deprecated and subject for removal;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martun martun martun approved these changes

Assignees

@vo-nil vo-nil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vo-nil @martun