Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TODOs in marshalling #84

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix TODOs in marshalling #84

merged 1 commit into from
Oct 15, 2024

Conversation

vo-nil
Copy link
Contributor

@vo-nil vo-nil commented Oct 14, 2024

closes #73

@vo-nil vo-nil self-assigned this Oct 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

Clang Test Results

  158 files  ±0    158 suites  ±0   10m 53s ⏱️ -1s
3 231 tests ±0  3 225 ✅ ±0  6 💤 ±0  0 ❌ ±0 
3 301 runs  ±0  3 295 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 70135ef. ± Comparison against base commit f2f6baf.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

Gcc Test Results

  158 files  ±0    158 suites  ±0   12m 12s ⏱️ -1s
3 231 tests ±0  3 225 ✅ ±0  6 💤 ±0  0 ❌ ±0 
3 301 runs  ±0  3 295 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 70135ef. ± Comparison against base commit f2f6baf.

♻️ This comment has been updated with latest results.

@vo-nil vo-nil force-pushed the 73-todos-in-marshalling branch 2 times, most recently from 485f169 to 7217cd1 Compare October 15, 2024 09:04
@vo-nil vo-nil requested a review from martun October 15, 2024 11:16
@vo-nil vo-nil marked this pull request as ready for review October 15, 2024 11:17
@vo-nil
add outcome to lpc marshalling, todos #73
c185fae 
update marshalling for proof-producer #73

Remove r1cs marshalling tests and example, update todos for zk #73

todo merkle proof

abstract method generate_assignments #73

Leave merkle_proof as it is #73

todo in tests

reference operator=

remove dummy eq operator
@vo-nil vo-nil force-pushed the 73-todos-in-marshalling branch from 70135ef to c185fae Compare October 15, 2024 12:02
@vo-nil vo-nil merged commit e1625c7 into master Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martun martun martun approved these changes

Assignees

@vo-nil vo-nil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address TODOs in marshalling
2 participants
@vo-nil @martun