Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix single-threaded include #70

Merged
merged 19 commits into from
Oct 10, 2024
Merged

Conversation

AndreyMlashkin
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Oct 7, 2024

Clang Test Results

  156 files    156 suites   10m 55s ⏱️
3 230 tests 3 224 ✅ 6 💤 0 ❌
3 297 runs  3 291 ✅ 6 💤 0 ❌

Results for commit 91220e7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 7, 2024

Gcc Test Results

  156 files    156 suites   12m 24s ⏱️
3 230 tests 3 224 ✅ 6 💤 0 ❌
3 297 runs  3 291 ✅ 6 💤 0 ❌

Results for commit 91220e7.

♻️ This comment has been updated with latest results.

@AndreyMlashkin AndreyMlashkin force-pushed the fix-parallel-crypto3-usage branch from 4b2b356 to 2fc3a72 Compare October 9, 2024 08:21
Copy link

Copy link
Collaborator

@akokoshn akokoshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which kind of proof-producer used on CI? if only multi threaded - make sense add single threaded too

flake.nix Show resolved Hide resolved
flake.nix Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Show resolved Hide resolved
proof-producer/bin/proof-producer/CMakeLists.txt Outdated Show resolved Hide resolved
@martun
Copy link
Contributor

martun commented Oct 9, 2024

@AndreyMlashkin I ran "nix develop .#proof-producer", which is supposed to use multi-threaded crypto3, but I'm still able to build target proof-producer-single-threaded. Can we change something in such a way, that only proof-producer-multi-threaded is available? Or just have 1 target now, "proof-producer", which will be single or multi-threaded based on the nix environment.

zkevm-framework/zkevm-framework.nix Show resolved Hide resolved
flake.nix Show resolved Hide resolved
@akokoshn
Copy link
Collaborator

akokoshn commented Oct 9, 2024

After nix build assigner still used single threaded headers.
By the way nix build install both crypto3 and parallel-crypto3

@AndreyMlashkin AndreyMlashkin merged commit d47ddd3 into master Oct 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants