Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to new satisfiliability check #346

Merged
merged 5 commits into from
Feb 27, 2025
Merged

Conversation

oclaw
Copy link
Contributor

@oclaw oclaw commented Feb 25, 2025

Unified old and new implementation of satisfiability check (from the circuit builder and a free function one) and made it multi-threaded

Also deleted assignment and circuit proxy classes from blueprint as there is no need for them anymore

Copy link

github-actions bot commented Feb 25, 2025

Clang Test Results

  214 files   -  1    214 suites  ±0   36m 11s ⏱️ - 11m 32s
8 639 tests  - 10  8 631 ✅  - 10   8 💤 ±0  0 ❌ ±0 
8 885 runs   - 10  8 873 ✅  - 10  12 💤 ±0  0 ❌ ±0 

Results for commit 1d98556. ± Comparison against base commit 977dced.

This pull request removes 11 and adds 1 tests. Note that renamed tests count towards both.
blueprint_assignment_proxy_constant_test
blueprint_assignment_proxy_public_input_test
blueprint_assignment_proxy_save_shared_test
blueprint_assignment_proxy_selector_test
blueprint_assignment_proxy_shared_test
blueprint_assignment_proxy_witness_test
blueprint_circuit_proxy_copy_constraints_test
blueprint_circuit_proxy_gates_test
blueprint_circuit_proxy_lookup_gates_test
blueprint_circuit_proxy_lookup_tables_test
…
jacobi_tests ‑ jacobi_test

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 25, 2025

Gcc Test Results

  214 files   -  1    214 suites   - 1   33m 43s ⏱️ - 12m 41s
8 639 tests  - 11  8 631 ✅  - 11   8 💤 ±0  0 ❌ ±0 
8 885 runs   - 11  8 873 ✅  - 11  12 💤 ±0  0 ❌ ±0 

Results for commit 1d98556. ± Comparison against base commit 977dced.

This pull request removes 11 tests.
blueprint_assignment_proxy_constant_test
blueprint_assignment_proxy_public_input_test
blueprint_assignment_proxy_save_shared_test
blueprint_assignment_proxy_selector_test
blueprint_assignment_proxy_shared_test
blueprint_assignment_proxy_witness_test
blueprint_circuit_proxy_copy_constraints_test
blueprint_circuit_proxy_gates_test
blueprint_circuit_proxy_lookup_gates_test
blueprint_circuit_proxy_lookup_tables_test
…

♻️ This comment has been updated with latest results.

@oclaw oclaw force-pushed the feature/multithread_sat_check branch 3 times, most recently from 9989540 to 9a367dd Compare February 25, 2025 18:40
@oclaw oclaw marked this pull request as ready for review February 25, 2025 19:38
Copy link

@oclaw oclaw requested a review from akokoshn February 26, 2025 11:49
@oclaw oclaw force-pushed the feature/multithread_sat_check branch from d6bca31 to 10b2896 Compare February 26, 2025 17:22
@oclaw oclaw force-pushed the feature/multithread_sat_check branch from 10b2896 to 06182a5 Compare February 27, 2025 11:08
@oclaw oclaw force-pushed the feature/multithread_sat_check branch from 06182a5 to 6cbff64 Compare February 27, 2025 11:15
@oclaw oclaw added this pull request to the merge queue Feb 27, 2025
Merged via the queue into master with commit f0695a9 Feb 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants