Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang sanitizers #20

Merged
merged 13 commits into from
Nov 27, 2024
Merged

Add clang sanitizers #20

merged 13 commits into from
Nov 27, 2024

Conversation

AndreyMlashkin
Copy link
Collaborator

No description provided.

@AndreyMlashkin AndreyMlashkin force-pushed the add-clang-sanitizers branch 2 times, most recently from 4b7b356 to b98a71d Compare September 17, 2024 10:44
@AndreyMlashkin AndreyMlashkin marked this pull request as draft September 20, 2024 14:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Clang Test Results

  154 files  +1    154 suites  +1   12m 20s ⏱️ +2s
3 546 tests +5  3 540 ✅ +5  6 💤 ±0  0 ❌ ±0 
3 606 runs  +5  3 600 ✅ +5  6 💤 ±0  0 ❌ ±0 

Results for commit 5cfb8dd. ± Comparison against base commit 925420c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Gcc Test Results

  155 files  +  2    155 suites  +2   35m 56s ⏱️ + 21m 42s
3 543 tests +  2  3 537 ✅ +  2  6 💤 ±0  0 ❌ ±0 
3 702 runs  +101  3 696 ✅ +101  6 💤 ±0  0 ❌ ±0 

Results for commit 5cfb8dd. ± Comparison against base commit 925420c.

This pull request removes 6 and adds 8 tests. Note that renamed tests count towards both. 
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4

lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
polynomial_dfs_benchmark_test_suite ‑ dummy_test
polynomial_dfs_benchmark_test_suite ‑ polynomial_product_test
polynomial_dfs_benchmark_test_suite ‑ polynomial_sum_real_test
thread_pool_test_suite ‑ vector_multiplication_test

♻️ This comment has been updated with latest results.

@AndreyMlashkin AndreyMlashkin force-pushed the add-clang-sanitizers branch 3 times, most recently from 0c7bd38 to 47dc00c Compare September 26, 2024 08:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

Sanitizers Test Results

  154 files      6 errors  148 suites   1h 10m 34s ⏱️
3 372 tests 3 366 ✅ 6 💤 0 ❌
3 432 runs  3 426 ✅ 6 💤 0 ❌

For more details on these parsing errors, see this check.

Results for commit 02556c7.

♻️ This comment has been updated with latest results.

@AndreyMlashkin AndreyMlashkin marked this pull request as ready for review September 27, 2024 08:36
@AndreyMlashkin AndreyMlashkin force-pushed the add-clang-sanitizers branch 3 times, most recently from cc55918 to b471b81 Compare October 14, 2024 09:06
@AndreyMlashkin AndreyMlashkin marked this pull request as draft October 25, 2024 14:26
@AndreyMlashkin AndreyMlashkin force-pushed the add-clang-sanitizers branch 5 times, most recently from f92fd87 to 152715f Compare November 8, 2024 07:19
@AndreyMlashkin AndreyMlashkin marked this pull request as ready for review November 25, 2024 18:02
akokoshn
akokoshn reviewed Nov 25, 2024
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
parallel-crypto3/libs/parallelization-utils/test/thread_pool.cpp Outdated Show resolved Hide resolved
@akokoshn akokoshn requested a review from makxenov November 25, 2024 20:46
akokoshn
akokoshn reviewed Nov 26, 2024
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@AndreyMlashkin AndreyMlashkin force-pushed the add-clang-sanitizers branch 2 times, most recently from fed52ea to 36eaffe Compare November 26, 2024 13:39
akokoshn
akokoshn reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@akokoshn akokoshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's enable:
crypto3-clang-sanitize
crypto3-clang-bench
crypto3-gcc-bench
parallel-crypto3-clang-sanitize
parallel-crypto3-clang-bench
parallel-crypto3-gcc-bench

flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
akokoshn
akokoshn reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@akokoshn akokoshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait approve from @martun

crypto3/benchmarks/CMakeLists.txt Outdated Show resolved Hide resolved
@akokoshn akokoshn requested a review from martun November 27, 2024 12:56
@AndreyMlashkin AndreyMlashkin added this pull request to the merge queue Nov 27, 2024
Merged via the queue into master with commit b562df9 Nov 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akokoshn akokoshn akokoshn approved these changes

@martun martun martun approved these changes

@makxenov makxenov Awaiting requested review from makxenov

Assignees

@AndreyMlashkin AndreyMlashkin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreyMlashkin @martun @akokoshn