Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review marshalling core #186

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Review marshalling core #186

merged 1 commit into from
Dec 15, 2024

Conversation

vo-nil
Copy link
Contributor

@vo-nil vo-nil commented Dec 9, 2024

closes #185

This PR cleanups unused code from marshalling/core

@vo-nil vo-nil force-pushed the 185-review-marshalling-core branch from c498e7d to 7d6d5df Compare December 11, 2024 12:05
@vo-nil vo-nil self-assigned this Dec 11, 2024
@vo-nil vo-nil force-pushed the 185-review-marshalling-core branch 4 times, most recently from 8dffafd to 50f65b6 Compare December 13, 2024 20:43
@vo-nil
Removed custom adapter options from adapt_basic_field
af52a6d 
Removed units support (kilo/mega/giga etc)
Removed unused structures and options
@vo-nil vo-nil force-pushed the 185-review-marshalling-core branch from 2d933ef to af52a6d Compare December 13, 2024 20:51
@vo-nil vo-nil marked this pull request as ready for review December 13, 2024 20:52
@vo-nil vo-nil requested a review from martun December 13, 2024 20:52
@vo-nil vo-nil enabled auto-merge December 13, 2024 20:52
@github-actions GitHub Actions
Copy link

Clang Test Results

  159 files   - 1    159 suites   - 1   18m 8s ⏱️ -19s
3 077 tests  - 4  3 071 ✅  - 4  6 💤 ±0  0 ❌ ±0 
3 165 runs   - 4  3 159 ✅  - 4  6 💤 ±0  0 ❌ ±0 

Results for commit af52a6d. ± Comparison against base commit 4923e9e.

This pull request removes 103 and adds 99 tests. Note that renamed tests count towards both. 
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4
types_accumulator_test_suite ‑ test100
types_accumulator_test_suite ‑ test26
types_accumulator_test_suite ‑ test27
types_accumulator_test_suite ‑ test28
…

pack_equal_test_suite ‑ bubb_to_bubb_1
pack_equal_test_suite ‑ bubb_to_bubb_2
pack_equal_test_suite ‑ bubb_to_bubb_3
pack_equal_test_suite ‑ bubb_to_bulb_1
pack_equal_test_suite ‑ bubb_to_bulb_2
pack_equal_test_suite ‑ bubb_to_lubb_1
pack_equal_test_suite ‑ bubb_to_lubb_2
pack_equal_test_suite ‑ bubb_to_lubb_3
pack_equal_test_suite ‑ bubb_to_lulb_1
pack_equal_test_suite ‑ bubb_to_lulb_2
…

@github-actions GitHub Actions
Copy link

Gcc Test Results

  159 files   -   1    159 suites   - 1   19m 7s ⏱️ +8s
3 077 tests  - 101  3 071 ✅  - 101  6 💤 ±0  0 ❌ ±0 
3 165 runs   - 101  3 159 ✅  - 101  6 💤 ±0  0 ❌ ±0 

Results for commit af52a6d. ± Comparison against base commit 4923e9e.

This pull request removes 101 tests. 
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
types_accumulator_test_suite ‑ test100
types_accumulator_test_suite ‑ test26
types_accumulator_test_suite ‑ test27
types_accumulator_test_suite ‑ test28
types_accumulator_test_suite ‑ test29
types_accumulator_test_suite ‑ test30
…

@vo-nil vo-nil added this pull request to the merge queue Dec 15, 2024
Merged via the queue into master with commit dd5b841 Dec 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martun martun martun approved these changes

Assignees

@vo-nil vo-nil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review marshalling/core library
2 participants
@vo-nil @martun