Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a class gate optimizer which will be responsible for making optimizations to the created circuit. #166

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Create a class gate optimizer which will be responsible for making optimizations to the created circuit. #166

wants to merge 3 commits into from

Conversation

martun
Copy link
Contributor

@martun martun commented Dec 2, 2024

Create a class gate optimizer which will be responsible for making optimizations to the created circuit. Currently it just tries to remove redundant selectors, and re-use some other selector by rotating the constraints.

@martun martun self-assigned this Dec 2, 2024
@martun martun linked an issue Dec 2, 2024 that may be closed by this pull request
Create a class gate_optimizer, which will be responsible for making optimizations to the created circuit. #155
Open
@martun martun force-pushed the 155-create-a-class-gate_optimizer-which-will-be-responsible-for-making-optimizations-to-the-created-circuit branch 2 times, most recently from f985249 to ca4e0bc Compare December 2, 2024 09:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

Clang Test Results

  145 files  + 1    145 suites  +1   11m 57s ⏱️ -1s
3 443 tests +98  3 437 ✅ +98  6 💤 ±0  0 ❌ ±0 
3 500 runs  +98  3 494 ✅ +98  6 💤 ±0  0 ❌ ±0 

Results for commit db5f190. ± Comparison against base commit e3f0d60.

This pull request removes 6 and adds 104 tests. Note that renamed tests count towards both. 
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4

blueprint_bbf_gates_optimizer_test_suite ‑ blueprint_plonk_bbf_gates_optimizer_test
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
pack_equal_test_suite ‑ bubb_to_bubb_1
pack_equal_test_suite ‑ bubb_to_bubb_2
pack_equal_test_suite ‑ bubb_to_bubb_3
pack_equal_test_suite ‑ bubb_to_bulb_1
pack_equal_test_suite ‑ bubb_to_bulb_2
…

♻️ This comment has been updated with latest results.

@martun martun force-pushed the 155-create-a-class-gate_optimizer-which-will-be-responsible-for-making-optimizations-to-the-created-circuit branch from ca4e0bc to f6a1ee0 Compare December 2, 2024 10:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

Gcc Test Results

  146 files  + 1    146 suites  +1   35m 45s ⏱️ -2s
3 446 tests +98  3 440 ✅ +98  6 💤 ±0  0 ❌ ±0 
3 503 runs  +98  3 497 ✅ +98  6 💤 ±0  0 ❌ ±0 

Results for commit b2ffa4d. ± Comparison against base commit e3f0d60.

This pull request removes 6 and adds 104 tests. Note that renamed tests count towards both. 
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4

blueprint_bbf_gates_optimizer_test_suite ‑ blueprint_plonk_bbf_gates_optimizer_test
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
pack_equal_test_suite ‑ bubb_to_bubb_1
pack_equal_test_suite ‑ bubb_to_bubb_2
pack_equal_test_suite ‑ bubb_to_bubb_3
pack_equal_test_suite ‑ bubb_to_bulb_1
pack_equal_test_suite ‑ bubb_to_bulb_2
…

♻️ This comment has been updated with latest results.

@martun martun marked this pull request as draft December 11, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayashunsky ayashunsky ayashunsky approved these changes

@ETatuzova ETatuzova Awaiting requested review from ETatuzova

Assignees

@martun martun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a class gate_optimizer, which will be responsible for making optimizations to the created circuit.
2 participants
@martun @ayashunsky