abstract method generate_assignments #73

NilFoundation · Oct 15, 2024 · cf0faca · cf0faca
1 parent 55a1c30
commit cf0faca
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/crypto3/libs/blueprint/include/nil/blueprint/zkevm/zkevm_operation.hpp b/crypto3/libs/blueprint/include/nil/blueprint/zkevm/zkevm_operation.hpp
@@ -69,7 +69,7 @@ namespace nil {
             // we expect that most of the operations would only use MIDDLE_OP
             virtual std::map<gate_class, std::vector<constraint_type>> generate_gates(zkevm_circuit_type &zkevm_circuit) = 0;
 
-            virtual void generate_assignments(zkevm_circuit_type &zkevm_circuit, zkevm_machine_interface &machine);
+            virtual void generate_assignments(zkevm_circuit_type &zkevm_circuit, zkevm_machine_interface &machine) = 0;
             // should return the same rows amount for everyс operation right now
             // here in case we would make it dynamic in the future
             virtual std::size_t rows_amount() = 0;

diff --git a/crypto3/libs/blueprint/test/zkevm/opcodes/div.cpp b/crypto3/libs/blueprint/test/zkevm/opcodes/div.cpp
@@ -35,7 +35,7 @@
 #include <nil/blueprint/zkevm/zkevm_circuit.hpp>
 #include "../opcode_tester.hpp"
 
-#include <nil/blueprint/zkevm/operations/mul.hpp>
+#include <nil/blueprint/zkevm/operations/div.hpp>
 
 using namespace nil::blueprint;
 using namespace nil::crypto3::algebra;

diff --git a/...o3/libs/zk/include/nil/crypto3/zk/snark/arithmetization/plonk/lookup_table_definition.hpp b/...o3/libs/zk/include/nil/crypto3/zk/snark/arithmetization/plonk/lookup_table_definition.hpp
@@ -76,7 +76,7 @@ namespace nil {
                     plonk_lookup_table<FieldType> lookup_table;
                     std::string name;
 
-                    dynamic_table_definition(std::string _name): name(_name), defined(false) {}
+                    dynamic_table_definition(std::string _name): defined(false), name(_name) {}
 
                     void define(const plonk_lookup_table<FieldType> &table){
                         BOOST_ASSERT(!defined);