Fix hopper task termination after single execution and refactor for Folia thread-safety#92
Merged
Merged
Conversation
- Fix bug where hopper tasks would stop after one execution by ensuring proper task restart in startHopperTask - Wrap restartHopperForSpawner in location-based scheduler for Folia thread-safety - Add atomic task replacement: stopHopperTask before starting new one to prevent race conditions - Add comprehensive null checks throughout all hopper methods - Improve error handling with try-catch blocks and detailed logging - Optimize cleanup method to safely cancel all tasks - Add validation checks in processChunkHoppers and onChunkUnload - Ensure thread-safe access to activeHoppers ConcurrentHashMap Co-authored-by: ptthanh02 <73684260+ptthanh02@users.noreply.github.com>
- Add cleanup of old HopperHandler before creating new one in setUpHopperHandler - Prevents resource leaks and duplicate tasks when config is reloaded - Ensures all old hopper tasks are properly cancelled before restart Co-authored-by: ptthanh02 <73684260+ptthanh02@users.noreply.github.com>
- Rename tileEntities to hopperStates for better clarity - Inline checkDelay variable for better readability Co-authored-by: ptthanh02 <73684260+ptthanh02@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bug in hopper functionality and refactor for performance
Fix hopper task termination after single execution and refactor for Folia thread-safety
Nov 1, 2025
Contributor
|
@copilot > Task :api:javadocJar
|
…ities - Change BlockState[] to Collection<BlockState> for getTileEntities return type - Replace .length check with .isEmpty() for Collection - Fixes incompatible types compilation error in processChunkHoppers and onChunkUnload Co-authored-by: ptthanh02 <73684260+ptthanh02@users.noreply.github.com>
Contributor
Author
Fixed in b64fc4e. Changed Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
|
@copilot everything seem to be working, can you optimize HopperHandler.transferItems() further for performances |
Performance improvements: - Cache hopper inventory and contents outside loops to avoid repeated getContents() calls - Pre-allocate ArrayList with expected size to reduce resizing - Use itemTransferred flag to exit inner loop early instead of break - Cache currentAmount and maxStackSize to reduce method calls - Separate isSimilar check from amount check for better readability - Update hopperContents array after modification to keep cache synchronized These changes reduce unnecessary object allocations and method calls in the hot path, improving performance especially when processing multiple items per transfer cycle. Co-authored-by: ptthanh02 <73684260+ptthanh02@users.noreply.github.com>
Contributor
Author
Optimized in 3734aa0. Key improvements:
These changes significantly reduce object allocations and method calls in the transfer hot path. |
Contributor
|
@copilot But make sure Moved hopper.getInventory().getContents() outside the loop to avoid creating new arrays for every spawner item not exploit able since player can still interact with spawner while transfering items |
Moved getContents() call inside the outer loop (per spawner item) instead of caching it for the entire transfer operation. This prevents exploits where players could interact with the hopper during transfers, as we now get fresh inventory state for each item being transferred. Balance between performance and security: - Still cache hopperInv reference to avoid repeated getInventory() calls - Get fresh contents for each spawner item (not each hopper slot) - Removed stale cache update line that's no longer needed Addresses security concern while maintaining most performance improvements. Co-authored-by: ptthanh02 <73684260+ptthanh02@users.noreply.github.com>
Contributor
Author
Fixed in 01980fe. Moved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix hopper functionality and refactor for better performance and Folia thread-safety
Summary of Changes
Root Cause
The bug occurred because
startHopperTaskwould return early if a hopper location was already in the activeHoppers map, preventing task replacement whenrestartHopperForSpawnerwas called.Solution
startHopperTaskto atomically replace tasks by callingstopHopperTaskfirstrestartHopperForSpawnerin location-based scheduler for Folia thread-safetysetUpHopperHandlerto prevent resource leaks on reloadtransferItems()method with balanced performance and security approachFiles Modified
HopperHandler.java: Core hopper functionality fixes and performance optimizationsSmartSpawner.java: Cleanup on reloadKey Improvements
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.