Skip to content

[Refactor] drop misleading auto_activate field on SkillRecommendation #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NickCrew merged 1 commit into from
Jun 13, 2026
Merged

[Refactor] drop misleading auto_activate field on SkillRecommendation #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions claude_ctx_py/skill_recommender.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class SkillRecommendation:
triggers: List[str]
related_agents: List[str]
estimated_value: str # "high", "medium", "low"
auto_activate: bool # Activate if confidence >= 0.8

def should_notify(self) -> bool:
"""Determine if this recommendation should notify the user."""
Expand Down Expand Up @@ -380,7 +379,6 @@ def _rule_based_recommendations(
triggers=file_patterns,
related_agents=[],
estimated_value=self._estimate_value(rec_data["confidence"]),
auto_activate=rec_data["confidence"] >= 0.8
)
recommendations.append(rec)

Expand All @@ -403,7 +401,6 @@ def _agent_based_recommendations(
triggers=[f"agent:{agent_name}"],
related_agents=[agent_name],
estimated_value=self._estimate_value(confidence),
auto_activate=confidence >= 0.8
)
recommendations.append(rec)

Expand Down Expand Up @@ -452,7 +449,6 @@ def _semantic_skill_recommendations(
triggers=["semantic_match"],
related_agents=[],
estimated_value=self._estimate_value(confidence),
auto_activate=False,
)
)

Expand Down Expand Up @@ -518,7 +514,6 @@ def _pattern_based_recommendations(
triggers=["historical_pattern"],
related_agents=[],
estimated_value=self._estimate_value(confidence),
auto_activate=False # Never auto-activate pattern-based
)
recommendations.append(rec)

Expand Down
Loading