Skip to content

Modern CMake Build fix#6

Open
croi900 wants to merge 1 commit intoNicholaswogan:mainfrom
croi900:main
Open

Modern CMake Build fix#6
croi900 wants to merge 1 commit intoNicholaswogan:mainfrom
croi900:main

Conversation

@croi900
Copy link
Copy Markdown

@croi900 croi900 commented Jan 13, 2026

The current modern CMake versions cannot build the package because of the cmake_minimum_required(VERSION 3.0).

Changing it to be >= 3.6 will allow modern toolchains to build the package, making it usable again.

Moreover, when attempting to build following the version change, on gcc 15.2.1 20251112, the following error occured:

NumbaQuadpack/src/dqc25c.c:51:23: error: passing argument 2 of ‘G_K15W’ from incompatible pointer type [-Wincompatible-pointer-types]
   51 |     result = G_K15W(f,dqwgtc,c,p2,p3,p4,kp,a,b,abserr,&resabs,&resasc, user_data);
      |                       ^~~~~~
      |                       |
      |                       double (*)(double,  double,  double,  double,  double,  int)

by introducing dq_weight_function_type this error no longer occurs and the library builds, so does the python package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant