Skip to content

Fix DomainOffensive certbot plugin #4406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chindocaine
Copy link

In #4235 the certbot plugin for do.de (Domain Offensive) was updated to use the more official version. One necessary line modification was missed, resulting in an error when creating a new certificate.

Also see the comments on the above mentioned PR in case you came here because cert renewal is broken.

Verified

This commit was signed with the committer’s verified signature.
RossBrunton Ross Brunton
In NginxProxyManager#4235 the certbot plugin for do.de (Domain Offensive) was updated to use the more
official version. One necessary line modification was missed, resulting in an error when creating a new certificate.
@nginxproxymanagerci
Copy link

Docker Image for build 1 is available on
DockerHub
as nginxproxymanager/nginx-proxy-manager-dev:pr-4406

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes
Note: this is a different docker image namespace than the official image

@FabianK3
Copy link
Contributor

Thank you for the fix.

Like yourself others had the same issue regarding not-transitioned values, is changing the variable name enough for transitioning everything else?

You mentioned that you renamed a bit more when you encountered the issue (#4235 (comment)).

@chindocaine
Copy link
Author

chindocaine commented Mar 31, 2025

Exactly, the linked comment describes what I had to to to get my existing certificates to renew again. Unfortunately I don't know enough about the inner workings of the Nginx Proxy Manager to figure out if this could be automated for other users, so this PR doesn't address this issue. (And tbh I'm not sure if it's still worth fixing, because it has been broken for about 2 months now, so most existing certs will have expired anyway.)
This PR rather fixes the creation of new certificates with the do.de provider, which is currently also broken. In that case the problem is just the variable name that wasn't updated.

@FabianK3
Copy link
Contributor

And tbh I'm not sure if it's still worth fixing, because it has been broken for about 2 months now, so most existing certs will have expired anyway.

Valid point, i think that is acceptable.

Thank you for that fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants