Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $proxy_add_x_forwarded_for for custom locations #4348

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Ziron
Copy link

@Ziron Ziron commented Feb 6, 2025

Use $proxy_add_x_forwarded_for when setting X-Forwarded-For in custom locations to match how it is set for default location.

The proxy settings included in the default location uses $proxy_add_x_forwarded_for instead of $remote_addr since 052cb8f, which handles when NPM is behind multiple reverse proxies.

This commit makes sure the same setting is used when creating custom location blocks for a proxy host.

Use $proxy_add_x_forwarded_for when setting X-Forwarded-For in custom locations to match how it is set for default location
@nginxproxymanagerci
Copy link

Docker Image for build 1 is available on
DockerHub
as nginxproxymanager/nginx-proxy-manager-dev:pr-4348

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes
Note: this is a different docker image namespace than the official image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant