feat: add idempotent upsell trigger logic#60
Open
1275321348 wants to merge 2 commits into
Open
Conversation
Author
|
Extra implementation note: this PR keeps the upsell trigger logic isolated in a small helper layer and adds coverage for the main behavior: 5th-call threshold detection, duplicate prevention, response header output, trigger record shape, and deterministic prompt variant selection. It should be easy to review or move into a different integration point if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
Summary
X-Upsell-Prompt: trueand threshold metadata when the trigger fires.Validation
git diff --check.deno test tests/upsell.test.tscould not be executed locally.Notes
The existing migration for
upsell_triggersis already present in the repository, so this PR focuses on the expected TypeScript middleware/helper layer and tests.