[Feature/25] 보틀 상세 정보 조회 API를 구현한다 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injoon2019
approved these changes
Jul 23, 2024
|
|
||
| @Transactional(readOnly = true) | ||
| fun getBottle(bottleId: Long): Bottle { | ||
| return bottleRepository.findByIdOrNull(bottleId) ?: throw IllegalArgumentException("존재하지 않는 보틀입니다.") |
There was a problem hiding this comment.
nit) 저희가 예외 메시지를 던지면 클라이언트에서는 그걸로 모달창을 보여줄거에요! 서비스를 잘 모르는 유저 입장에서 "존재하지 않는 보틀입니다." 라고 했을 때 이해를 못할 수도 있을거 같은데 더 좋은 문구가 떠오르면 수정해도 좋아요!
디자인 시안을 봤을 때 전체적으로 ~해요 체를 쓰는거 같아서 문구를 맞춰도 좋을거 같아요. 당장 중요한건 아닙니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 이슈 번호
close: #25
✨ 작업 내용
보틀의 상세 정보를 조회하는 API를 구현했습니다.
🚀 전달 사항